Handle apostrophes in fingerprint glob paths#2879
Open
kv1sidisi wants to merge 1 commit into
Open
Conversation
kv1sidisi
commented
Jun 10, 2026
- Escape apostrophes when expanding fingerprint globs so quoted paths are parsed correctly.
- Add a regression test for a directory name that contains an apostrophe.
1 task
trulede
reviewed
Jul 15, 2026
trulede
left a comment
Contributor
There was a problem hiding this comment.
Seems OK, I offered some feedback.
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestGlobHandlesApostropheInPath(t *testing.T) { |
Contributor
There was a problem hiding this comment.
A table driven test, for each of the cases in the code, would be useful.
Contributor
There was a problem hiding this comment.
Actually, this test is not very useful. It would be better to make an Executor/Task test where you have a list of files including characters which should be escaped, then run the Task, then check the files are handled correctly. You might even find that such a test exists.
Such a test would cover the entire processing chain (in case it gets broken somewhere else too).
Comment on lines
93
to
+99
| func escape(s string) string { | ||
| s = filepath.ToSlash(s) | ||
| s = strings.ReplaceAll(s, " ", `\ `) | ||
| s = strings.ReplaceAll(s, "&", `\&`) | ||
| s = strings.ReplaceAll(s, "(", `\(`) | ||
| s = strings.ReplaceAll(s, ")", `\)`) | ||
| s = strings.ReplaceAll(s, "'", `\'`) |
Contributor
There was a problem hiding this comment.
Something like this would be better:
var pathReplacer = strings.NewReplacer(
" ", `\ `,
"&", `\&`,
"(", `\(`,
")", `\)`,
"'", `\'`,
)
func escape(s string) string {
s = filepath.ToSlash(s)
return pathReplacer.Replace(s)
}
But I also wonder if there are other characters which need escaping?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.